[ 
https://issues.apache.org/jira/browse/TOREE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048202#comment-16048202
 ] 

ASF GitHub Bot commented on TOREE-380:
--------------------------------------

Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/incubator-toree/pull/104#discussion_r121756270
  
    --- Diff: 
kernel/src/test/scala/org/apache/toree/kernel/protocol/v5/relay/ExecuteRequestRelaySpec.scala
 ---
    @@ -88,7 +89,7 @@ class ExecuteRequestRelaySpec extends TestKit(
             // Expected does not actually match real return of magic, which
             // is a tuple of ExecuteReply and ExecuteResult
             val expected = new ExecuteAborted()
    -        interpreterActorProbe.expectMsgClass(
    +        interpreterActorProbe.expectMsgClass(max = Duration(5, 
TimeUnit.SECONDS),
    --- End diff --
    
    The default is 3 seconds, but it was flaky for me. This was another 
work-around that probably shouldn't be here.


> Interpreters should be allowed to send results other than text/plain.
> ---------------------------------------------------------------------
>
>                 Key: TOREE-380
>                 URL: https://issues.apache.org/jira/browse/TOREE-380
>             Project: TOREE
>          Issue Type: Improvement
>            Reporter: Ryan Blue
>            Assignee: Ryan Blue
>
> Jupyter allows kernels to send results using different content types, but 
> this isn't allowed by Toree for its interpreters. This prevents custom 
> display logic. The basic problem is that {{ExecuteOutput}} is a {{String}} 
> and not a {{Map[String, String]}} like {{CellMagicOutput}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to