[ 
https://issues.apache.org/jira/browse/TOREE-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123256#comment-16123256
 ] 

ASF GitHub Bot commented on TOREE-430:
--------------------------------------

Github user Myllyenko commented on a diff in the pull request:

    https://github.com/apache/incubator-toree/pull/129#discussion_r132670358
  
    --- Diff: 
scala-interpreter/src/main/scala-2.10/org/apache/toree/kernel/interpreter/scala/ScalaInterpreterSpecific.scala
 ---
    @@ -61,6 +61,7 @@ trait ScalaInterpreterSpecific { this: ScalaInterpreter =>
       ): SparkIMain = {
         val s = new SparkIMain(settings, out)
         s.initializeSynchronous()
    +    System.setProperty("spark.repl.class.outputDir", 
s.getClassOutputDirectory.getAbsolutePath)
    --- End diff --
    
    I've tried to figure out how to do that without heavy code modifications 
but haven't succeeded.
    
    It worth noting that currently in a Scala 2.11 environment Toree [sets this 
property in a similar 
manner](https://github.com/apache/incubator-toree/blob/master/kernel/src/main/scala/org/apache/toree/boot/KernelBootstrap.scala#L70).
 And in Scala 2.11 we can pass it directly to `SparkConf` with ease because 
`spark.repl.class.outputDir`'s required value becomes known very early ([when 
`org.apache.spark.repl.Main` is 
initialised](https://github.com/apache/spark/blob/branch-1.6/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala#L33)).
    
    But in a Scala 2.10 environment, things are different. 
`spark.repl.class.outputDir`' [is initialised only with 
`org.apache.spark.repl.SparkIMain`](https://github.com/apache/spark/blob/branch-2.2/repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkIMain.scala#L100),
 that is after creation of `ScalaInterpreter` in Toree. But in order to pass 
`spark.repl.class.outputDir` directly to `SparkConf` we have to 
initialise`SparkIMain` earlier than Toree's `Kernel`.
    
    This is applicable for both Spark 2 and Spark 1.6.


> ClassNotFoundException with lambdas on CDH 5.10.0
> -------------------------------------------------
>
>                 Key: TOREE-430
>                 URL: https://issues.apache.org/jira/browse/TOREE-430
>             Project: TOREE
>          Issue Type: Bug
>          Components: Kernel
>    Affects Versions: 0.1.0
>         Environment: CDH 5.10.0 (Spark 1.6.0, Scala 2.10.5)
>            Reporter: Igor Melnichenko
>
> In the specified environment, Toree classloader fails to load classes defined 
> and compiled in REPL. For instance, the following Spark example fails with 
> ClassNotFoundException and works fine if the lambda is removed:
> {code:title=Example.scala|borderStyle=solid}
> val NUM_SAMPLES = 100
> val count = sc.parallelize(1 to NUM_SAMPLES).filter { _ =>
>   val x = math.random
>   val y = math.random
>   x*x + y*y < 1
> }.count()
> println(s"Pi is roughly ${4.0 * count / NUM_SAMPLES}")
> {code}
> Cause: a location of a directory used by a REPL compiler to store 
> runtime-compiled classes is different from a location where classloader tries 
> to find these classes.
> PR with fix will be opened soon.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to