[
https://issues.apache.org/jira/browse/TOREE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931927#comment-16931927
]
ASF GitHub Bot commented on TOREE-504:
--------------------------------------
kevin-bates commented on pull request #172: [TOREE-504] Add protocol version to
shutdown_reply header
URL: https://github.com/apache/incubator-toree/pull/172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Version missing from shutdown_reply header
> ------------------------------------------
>
> Key: TOREE-504
> URL: https://issues.apache.org/jira/browse/TOREE-504
> Project: TOREE
> Issue Type: Bug
> Components: Kernel
> Affects Versions: 0.3.0
> Reporter: Kevin Bates
> Assignee: Kevin Bates
> Priority: Major
> Fix For: 0.4.0
>
>
> The 5.0 Jupyter message protocol adds a {{version}} field to [message
> headers|https://jupyter-client.readthedocs.io/en/latest/messaging.html#general-message-format].
> However, shutdown_reply headers are not setting the protocol version. As a
> result, clients that adhere to the protocol can have issues when {{version}}
> is present in the response header as an empty string, leading to noise and
> possible incorrect behaviors following Toree's shutdown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
