[
https://issues.apache.org/jira/browse/TOREE-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009779#comment-17009779
]
ASF GitHub Bot commented on TOREE-511:
--------------------------------------
kevin-bates commented on pull request #181: [TOREE-511] Rework make jupyter
build tasks
URL: https://github.com/apache/incubator-toree/pull/181#discussion_r363776548
##########
File path: Makefile
##########
@@ -15,7 +15,10 @@
# limitations under the License
#
-.PHONY: help clean clean-dist build dev test system-test test-travis release
pip-release bin-release dev-binder .binder-image audit audit-licenses
+.PHONY: help clean clean-dist .clean-binder-image .clean-toree-dev-image \
+ build dev test system-test test-travis release pip-release bin-release \
+ dev-binder .binder-image .toree-dev-image \
Review comment:
`.binder-image` and `.toree-dev-image` should not be listed here as they
correspond to files that _are_ the target.
Also, do we need the '.' prefix on `.clean-binder-image` and
`.clean-toree-dev-image`? I think the dotted notation is purely because we
don't want the files visible by default. Because these are PHONY targets, I
think removing the dotted prefix is appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rework "make dev/make jupyter" build tasks
> ------------------------------------------
>
> Key: TOREE-511
> URL: https://issues.apache.org/jira/browse/TOREE-511
> Project: TOREE
> Issue Type: Task
> Components: Build
> Reporter: Luciano Resende
> Assignee: Luciano Resende
> Priority: Major
> Fix For: 0.4.0
>
>
> Toree has `make dev` and `make jupyter` commands that are using some old
> dependencies and some weird way to build them. We should create a docker
> file that extends from `jupyter/all-spark-notebook` to make maintenance
> easier.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
