[ 
https://issues.apache.org/jira/browse/TOREE-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016228#comment-17016228
 ] 

ASF GitHub Bot commented on TOREE-508:
--------------------------------------

gmcoringa commented on issue #180: [TOREE-508] Reply errors to iopub.error 
instead of iopub.exec_result
URL: https://github.com/apache/incubator-toree/pull/180#issuecomment-574800328
 
 
   > I believe we are going in the right direction here, but with the change on 
behavior the errors are not completely showing up on the notebook interface.
   > 
   > Original behavior:
   > 
![toree-508-original](https://user-images.githubusercontent.com/382917/72102913-e9819900-32dc-11ea-803d-4175c986128a.png)
   > 
   > And with the changes from this pr:
   > 
![toree-508-updated](https://user-images.githubusercontent.com/382917/72102929-f30b0100-32dc-11ea-8262-93ea5c7646e6.png)
   > 
   > As shown in the picture above, the contents are not all there, and the 
cell is not scrollable anymore.
   
   The error is not completely showing because of the code below found in 
[ScalaInterpreterSpecific.scala#L429](https://github.com/apache/incubator-toree/blob/master/scala-interpreter/src/main/scala-2.11/org/apache/toree/kernel/interpreter/scala/ScalaInterpreterSpecific.scala#L429):
   ```java
           ExecuteError(
             ex.getClass.getName,
             ex.getLocalizedMessage,
             formattedException.slice(1, formattedException.size - 1).toList
           )
   ```
   Which removes the first line from the stack, I don't know why, but I believe 
that this should not be done.
   
   About the scrollable, testing with python kernels seems to have the same 
behaviour (errors are not scrollable).
   
   So @lresende if you think its better I can fix the removal of messages from 
the stack trace.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reply errors to iopub.error instead of iopub.exec_result
> --------------------------------------------------------
>
>                 Key: TOREE-508
>                 URL: https://issues.apache.org/jira/browse/TOREE-508
>             Project: TOREE
>          Issue Type: Bug
>            Reporter: Fabiano V. Santos
>            Priority: Major
>
> Errors of any kind (compilation, exceptions, etc) returns as normal results 
> instead of using iopub.error, so jupyter interpret the cell execution as 
> success which lead to problems if you use tools like papermill to schedule 
> notebooks, as you never know if the notebook execution was successfully or 
> not.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to