eliminate an unnecessary dependency? +1 (+1000 if I could...) . If it's kept around only for testing purposes, the tester should deal with that separately: perhaps a documentation update is warranted in that case.
-dan On Thu, Nov 15, 2018 at 10:40 AM Rivas, Jesse <[email protected]> wrote: > Hi Traffic Controllers, > > Currently, the .pkg script is failing to build the Traffic Router rpm > because the build_rpm.sh script for TR attempts to download > jdnssec-tools.jar from verisign ( > http://www.verisignlabs.com/dnssec-tools/packages/old-releases), which is > no longer available. Traffic Router used to leverage code from the > jdnssec-tools.jar for zone signing, but it has since been replaced with our > own implementation. All of the classes and subsequent tests that use the > jdnssec package were previously moved from “core” to a separate module in > Traffic Router (called “jdnssec”) that is not included in the maven build > by default, and was kept for legacy and testing purposes. I would like to > propose removing the JDNSSEC dependency from Traffic Router altogether; > this would include removing the jdnssec module in Traffic Router and > subsequent pom files, and removing the “installDnsSec” function from the > build_rpm.sh script in Traffic Router that attempts to download > jdnssec-tools.jar and fails if it is unsuccessful. > > Please let me know if there is any opposition to removing the external > JDNSSEC dependency from Traffic Router, as it is no longer used for zone > signing and is no longer available for download from verisign. > > -Jesse >
