I'm on board with 2, sounds like a good change. Regarding 1: PR #4881 - which I expect will be merged soon - will make server xmppIds randomly generated on creation, and read-only from then on. So if it's not necessary to set it, and not possible to change it, and only TR uses it, then why expose it at all through the `/servers` API? We could just remove it from API responses entirely, without bothering with the rename (except on a database level if someone wants to do that)
On Thu, Jul 16, 2020 at 3:10 PM Jeremy Mitchell <[email protected]> wrote: > With API v3 in the works for TC 5.0, should we take this opportunity to do > 2 things: > > 1. rename xmppId to hashId as that appears to be its real use as the hash > id that traffic router uses in its consistent hashing algorithm. > > (actually, xmppId is currently used as the hash id IF it exists else > hostname is used which can result in duplicate hash ids - > https://github.com/apache/trafficcontrol/issues/2156) > > 2. delete xmppPasswd as it appears to have no use. > > This PR is a step in the right direction, but wondering if we can go > farther - https://github.com/apache/trafficcontrol/pull/4881 > > Jeremy >
