Hey, Dave.. no finger pointing here.. We hadn't established any guidelines yet, so figured it was time to bring it up...
I had a PR myself yesterday that did the same thing... We're getting there!! -dan On Mon, Dec 5, 2016 at 4:22 PM, David Neuman <david.neuma...@gmail.com> wrote: > +1 and sorry for merging a PR without. I will make sure all files have them > before merging in the future. > > On Mon, Dec 5, 2016 at 15:48 Dan Kirkwood <dang...@apache.org> wrote: > >> Hi all.. We haven't really established a process for this, but to >> keep in compliance with Apache license guidelines, each source file >> should have the Apache license comment -- normally at the head of the >> file, but I think that's somewhat flexible. >> >> Still going thru files adding them, but when any new files get added, >> they really should have that header in them already. >> >> What do you all think of establishing a guideline that any PR is not >> merged until the license is present in each source file added? >> >> -dan >>
