Also -1 on requiring, +1 on recommending. I've worked in environments where every commit or PR required a case, and it sounds good, but in practice it often discourages things like code maintenance and fixing technical debt.
> Maybe issue / mailing list discussion required for new features and optional for bugs? What about things that aren't really bugs or features? But, I don't think we should hesitate to say "Hey, you made this nontrivial PR feature/bug/refactor without talking to anyone, could you post about it on the mailing list, or make a case for it, to make sure the community is ok with it before we merge it in?" On Wed, Feb 15, 2017 at 8:16 PM, Jeremy Mitchell <[email protected]> wrote: > It kinda seems like our contributing.md file already implies that an issue > is required - > https://github.com/apache/incubator-trafficcontrol/blob/ > master/CONTRIBUTING.md > > Obviously, it slows down the process to have to create a jira issue, > discuss on the mailing list....for EVERY PR. > > Maybe issue / mailing list discussion required for new features and > optional for bugs? > > On Wed, Feb 15, 2017 at 8:07 PM, David Neuman <[email protected]> > wrote: > > > I am -1 on it being "required" however, I am ok with saying we prefer > it. > > > > > > On Wed, Feb 15, 2017 at 20:04 Jeremy Mitchell <[email protected]> > > wrote: > > > > > Should we require a Jira issue for each PR? I don't think it's a bad > idea > > > personally. And if we do require a Jira issue, it would be nice imo to > > see > > > each PR entitled like "[TC-XXX] - fixes blah blah" > > > > > > Jeremy > > > > > > On Tue, Feb 14, 2017 at 2:16 PM, Leif Hedstrom <[email protected]> > wrote: > > > > > > > Hi all, > > > > > > > > since we now have a process which lets us create Github PRs, without > > > first > > > > filing a bug report / issue, I’ve come to find that it’s many times > > > > difficult to know what “issue” a particular PR is addressing. So, I > > would > > > > like to suggest that we all make an effort to put more Description > text > > > in > > > > Github PRs, which do not have a Github Issue filed already. > > > > > > > > I’m also writing up a little bit of this into the CONTRIBUTING.md. > > > > > > > > Thanks, > > > > > > > > — Leif > > > > > > > > > > > > > >
