Please take a look at the master branch vs 2.1.x (or 2.0.x). I noticed that master doesn't have these extra "This close #xxxx". I believe were there because of the ASF git merges. Should these manual merges with empty commits not occur anymore?
For example, when I use github-changes between these 2 releases, I get no "pull requests". I can't really explain. So looks like we would need to use the milestones for now. root@af6c48399809:/# github-changes -o apache -r incubator-trafficcontrol -a --use-commit-body --only-pulls -b master --between-tags RELEASE-2.0.0...RELEASE-2.1.0-RC1 root@af6c48399809:/# more CHANGELOG.md ## Change Log ### RELEASE-2.1.0-RC1 (2017/10/16 17:10 +00:00) - [#1](https://github.com/apache/incubator-trafficcontrol/pull/1) Merging master (@dangogh, @mitchell852, @limited, @zhilhuan, @dewrich, @rob05c, @alficles, @DylanVolz, @nir-sopher, @dneuman64, @dg4pre z, @mdb, @rscrimojr, @elsloo, @knutsel, @rawlinp) But using --between-tags RELEASE-1.6.0...RELEASE-1.7.0 works just fine... ### RELEASE-1.7.0 (2016/10/14 18:30 +00:00) - [#2027](https://github.com/apache/incubator-trafficcontrol/pull/2027) Google::ProtocolBuffers to previous version (@dangogh) - [#2026](https://github.com/apache/incubator-trafficcontrol/pull/2026) adds back route that got deleted (@mitchell852) - [#2023](https://github.com/apache/incubator-trafficcontrol/pull/2023) updates for TOv2 experimental (@mitchell852) ... On Thu, Oct 26, 2017 at 4:56 PM, Phil Sorber <[email protected]> wrote: > I agree with Dave. > > On Thu, Oct 26, 2017 at 1:59 PM Hank Beatty <[email protected]> wrote: > > > Not currently. We either need to use a different script to generate the > > changelog or go back and modify all of the > > PRs/commits to have the 2.1.0 milestone. > > > > Give me until tomorrow because I would like to look at the other one that > > I presented. > > > > Hank > > > > On 10/26/2017 01:42 PM, Eric Friedrich (efriedri) wrote: > > > Do PRs/issues that don’t have a milestone assigned still end up in this > > changelog? I know theres a bunch more that went into 2.1 that isn’t in > this > > list. > > > > > > Should we make sure that every PR/Issue is assigned a milestone before > > its merged? > > > > > >> On Oct 26, 2017, at 12:52 PM, Hank Beatty <[email protected]> wrote: > > >> > > >> Thanks Phil this is very nice. > > >> > > >> Both of these scripts use the "milestones" to generate the changelog. > > Currently there are 21 issues associated with the 2.1.0 milestone. > > >> > > >> Here is the output of the one in TC: > > >> > > >> Changes with Traffic Control 2.1.0 > > >> #878 - [TC-488] Docs - Multi Site Origin not up to date > > >> #879 - [TC-490] mso.qstring_handling parameter is checked but not > > documented > > >> #880 - [TC-489] Multi Site Origin - Invalid default values for > > multiple config params > > >> #901 - [TC-377] Default profiles for EDGE and MID are missing after > > initial install > > >> #906 - [TC-327] ConfigFiles.pm detects blank as not null and tries > to > > gen files GH #1090 > > >> #909 - [TC-301] creating https delivery service and not setting to > > active still looks for cert. Github Issue #1086 > > >> #912 - [TC-169] TR download the RGB file continuously when the same > > RGB file on server > > >> #915 - [TC-116] remap.config order is different on master (postgres) > > than it is on 1.8. > > >> #980 - [TC-552] Global parameters may be duplicated when seeds.sql > is > > run > > >> #988 - [TC-514] ORT: Change Traffic Ops hostname in middle of ORT > run > > >> #1001 - [TC-408] Documentation for creating ssl keys is missing a > > field. > > >> #1090 - [TC-518] ToCDUCheck and ToCHRCheck: Value formatted as float > > instead of int > > >> #1115 - [TC-429] - TP - removes map due to license incompatibility > > >> #1118 - POST /api/1.2/deliveryserviceserver doesn't update header > > rewrite, regex remap and cacheurl > > >> #1167 - [BACKPORT][TC-518] ToCDUCheck and ToCHRCheck: Value > formatted > > as float instead of int #1090 > > >> #1168 - [BACKPORT][TC-514] ORT: Change Traffic Ops hostname in > middle > > of ORT run > > >> #1195 - [Issue-1189] - Backport to 2.1.x - delivery service tenancy > > is forced on creation and update if use_tenancy is on > > >> #1375 - BACKPORT - fix docs for Deliveryservice/sslkeys/generate > and > > deliveryservice/ssl… > > >> #1386 - Traffic Portal V2 main menu has two rows labeled "Tenants" > > >> > > >> > > >> On 10/26/2017 11:55 AM, Phil Sorber wrote: > > >>> I believe this one has had a little more love recently and does > things > > like > > >>> only include merged pull requests, etc. > > >>> https://github.com/apache/trafficserver/blob/master/ > tools/changelog.pl > > >>> On Thu, Oct 26, 2017 at 9:52 AM Phil Sorber <[email protected]> > wrote: > > >>>> You guys mean like this? > > >>>> > > >>>> > > >>>> > > https://github.com/apache/incubator-trafficcontrol/blob/ > master/misc/changelog.pl > > >>>> > > >>>> On Thu, Oct 26, 2017 at 8:39 AM Hank Beatty <[email protected]> > > wrote: > > >>>> > > >>>>> I was thinking of starting with something like this: > > >>>>> > > https://github.com/skywinder/github-changelog-generator#output-example. > > >>>>> I will also look at the github-changes that Steve mentions. > > >>>>> > > >>>>> Hank > > >>>>> > > >>>>> On 10/26/2017 08:48 AM, Steve Malenfant wrote: > > >>>>>> Do we have a sample from a script that would create a change log > > based > > >>>>> on > > >>>>>> pull request only? I tried `github-changes` yesterday but it > seemed > > to > > >>>>> work > > >>>>>> only with the older releases (<1.8). Although I haven't spent much > > time > > >>>>> on > > >>>>>> it. > > >>>>>> > > >>>>>> We should probably only list the high level changes such as new > > >>>>> features, > > >>>>>> improvements, important fixes and breaking changes (relates to > > >>>>> operations > > >>>>>> action required). > > >>>>>> > > >>>>>> Few things we should note as well : > > >>>>>> - How to upgrade from pre-2.0 releases > > >>>>>> - What are the upgrade procedures (run postinstall for example) > > >>>>>> - Profiles locations (not included in 2.x basic install anymore) > > >>>>>> > > >>>>>> I'm sure some of those are documented already, might just requires > > >>>>>> references. > > >>>>>> > > >>>>>> Steve > > >>>>>> > > >>>>>> > > >>>>>> > > >>>>>> On Wed, Oct 25, 2017 at 8:06 AM, Hank Beatty <[email protected]> > > >>>>> wrote: > > >>>>>> > > >>>>>>> Hello Steve, > > >>>>>>> > > >>>>>>> The release notes are still being worked on. I am also looking > for > > >>>>>>> suggestions on how the release notes should be formatted, and how > > they > > >>>>>>> might be auto-generated. If you have any, please let me know. > > >>>>>>> > > >>>>>>> Regards, > > >>>>>>> Hank > > >>>>>>> > > >>>>>>> On 10/24/2017 07:26 AM, Steve Malenfant wrote: > > >>>>>>> > > >>>>>>>> Is there any Release Notes associated with this release? 1,337 > > >>>>> changes and > > >>>>>>>> the link above will only display 250 of them. > > >>>>>>>> > > >>>>>>>> Steve > > >>>>>>>> > > >>>>>>>> On Mon, Oct 23, 2017 at 4:01 PM, Hank Beatty < > [email protected]> > > >>>>> wrote: > > >>>>>>>> > > >>>>>>>> Hello All, > > >>>>>>>>> > > >>>>>>>>> I've prepared a release for v2.1.0-RC1 > > >>>>>>>>> > > >>>>>>>>> The vote is open for at least 72 hours and passes if a majority > > of at > > >>>>>>>>> least 3 +1 PPMC votes are cast. > > >>>>>>>>> > > >>>>>>>>> [ ] +1 Approve the release > > >>>>>>>>> > > >>>>>>>>> [ ] -1 Do not release this package because ... > > >>>>>>>>> > > >>>>>>>>> Changes since 2.0.0: > > >>>>>>>>> https://github.com/apache/incubator-trafficcontrol/compare/ > > >>>>>>>>> 2.0.x...RELEASE-2.1.0-RC1 > > >>>>>>>>> > > >>>>>>>>> This corresponds to git: > > >>>>>>>>> Hash:6ea2ca86d07c16a3b3ca419dd56b975059271206 > > <(505)%20927-1206> <(505)%20927-1206> > > >>>>> <(505)%20927-1206> > > >>>>>>>>> <(505)%20927-1206> > > >>>>>>>>> Tag: RELEASE-2.1.0-RC1 > > >>>>>>>>> > > >>>>>>>>> Which can be verified with the following: git tag -v > > >>>>> RELEASE-2.1.0-RC1 > > >>>>>>>>> > > >>>>>>>>> My code signing key is available here: > > >>>>>>>>> https://pgp.mit.edu/pks/lookup?op=get&search= > 0x582D3F6E79270895 > > >>>>>>>>> > > >>>>>>>>> Make sure you refresh from a key server to get all relevant > > >>>>> signatures. > > >>>>>>>>> > > >>>>>>>>> The source .tar.gz file, pgp signature (.asc signed with my key > > from > > >>>>>>>>> above), md5 and sha512 checksums are provided here: > > >>>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/trafficcont > > >>>>>>>>> rol/2.1.0/RC1 > > >>>>>>>>> > > >>>>>>>>> Thanks! > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>> > > >>>>>> > > >>>>> > > >>>> > > > > > >
