His PR will update server.xml back to BIO —Eric
> On Jan 30, 2018, at 12:03 PM, David Neuman <[email protected]> wrote: > > Jeff is planning to open a PR to actually fix the leak or to update the > server.xml to use the BIO connector? > > On Tue, Jan 30, 2018 at 9:39 AM, Eric Friedrich (efriedri) < > [email protected]> wrote: > >> Thanks Dave- >> I’d like to keep it as a must-have in 2.2. We had a severe issue in >> production with the NIO connection when deploying 2.1. Jeff M is planning >> to open a PR to fix it in the 2.2 release. >> >> I understand the issue will be moot after upgrading to Tomcat, but the >> current 2.1 release has crippling TR scale problems out of the box and I’d >> like to avoid that with 2.2 given how small and low risk the fix is >> >> —Eric >> >>> On Jan 29, 2018, at 5:36 PM, Dave Neuman <[email protected]> wrote: >>> >>> Thanks Rob, >>> I think `916 [TC-197] File descriptor leak caused by NIO protocol >>> connector` should be moved to 2.3. This issue will be resolved with the >>> upgrade to Tomcat 8.5.x. >>> I don't think we should hold up the release for `1356 Step by Step >>> installation guide for new users`. I think it can be moved to 2.3 as >>> well. >>> I took a look at the issues in 2.3 and I am fine with what's there >> staying >>> there. >>> >>> Thanks, >>> Dave >>> >>> On Mon, Jan 29, 2018 at 11:47 AM, Robert Butts <[email protected]> wrote: >>> >>>> There are no `major` bugs without milestones, now. >>>> >>>> Many issues without milestones were moved from 2.1 to 2.2, and I moved >> them >>>> to 2.3 indiscriminately. We should verify they're ok to not be in 2.2. >>>> >>>> Traffic Ops >>>> -- >>>> 1026 [TC-191] Steering DS API should use standard response codes as >> defined >>>> in API guidelines >>>> 913 ort does not restart ATS when it should >>>> 911 Invalid DS regex causes nasty exception and unexpected results >> Github >>>> Issue #514 >>>> 905 Inactive delivery services are added to remap.config >>>> 902 api/1.2/deliveryservices/:id/routing.json hangs when Traffic >> Router is >>>> unreachable >>>> 899 IPv6 Origin Configuration Not Allowed >>>> 898 Clone DS assignments button on Server times out >>>> 896 Traffic Router statistics are not aggregated >>>> 892 GenIso can't handle concurrent requests >>>> 891 error_url required in the url_sig file >>>> 890 Should use "dest_ip" instead of "dest_domain" in "parent.config" and >>>> "cache.config" when ofqdn is ip >>>> 888 cacheurl_qstring.conf file is not generated when qstringIgnore=1 and >>>> location profile parameter is missing for edge/mid cache >>>> 885 Fix regression issues caused by TC-187 >>>> 882 Deleting a DS thru the TO API should also delete all SSL keys (if >>>> applicable) >>>> >>>> Traffic Router >>>> -- >>>> 914 Failed to restart tomcat in Traffic Router when failed to get SSL >> keys >>>> 907 Traffic Router requires at least one cache assigned to at least one >> DS >>>> for TLD zone generation >>>> >>>> >>>> There are 11 open issues in the 2.2 Milestone: >>>> >>>> Code >>>> -- >>>> 1777 TO golang -- api/1.3/parameters?orderby=id produces an error >>>> 1620 API: Server API sets xmpp_id to null >>>> 1397 ORT tries to get ats_uid before installing trafficserver >>>> 1042 [TC-242] tm_user.username and role should be NOT NULL in the db >>>> 986 [TC-544] TR should de-dupe Reponse Headers when sending a Steering >>>> response. >>>> 916 [TC-197] File descriptor leak caused by NIO protocol connector >>>> >>>> Documentation >>>> -- >>>> 1356 Step by Step installation guide for new users >>>> 1173 'Multi Site Origin Algorithm' is removed in delivery service UI in >>>> traffic_ops in TC-2.1 >>>> 1135 Traffic Server administration docs are out of date >>>> 1130 cacheurl is deprecated in ATS 7.x >>>> >>>> Licensing >>>> -- >>>> 1750 /traffic_ops/app/public/images/ contains non-free images >>>> >>>> >>>> Do we still feel like we can have all these fixed for a 2.2 Release in 2 >>>> weeks? Say, Monday, February 12? >>>> >>>> Are there any cases moved to 2.3 that need to be moved back and done in >>>> 2.2? >>>> >>>> Thanks, >>>> >> >>
