Fixed the license issues in
https://github.com/apache/incubator-trafficcontrol/pull/1880


On Tue, Feb 13, 2018 at 6:08 PM, Chris Lemmons <alfic...@gmail.com> wrote:

> -1 due to some licensing issues:
>
> - traffic_ops/testing/compare/vendor/github.com/kelseyhightower/envconfig
> is not identified as non-Apache licensed in the LICENSE file.
> - traffic_ops/testing/compare/vendor/github.com/x/net is not
> identified as non-Apache licensed in the LICENSE file.
>
> These libraries are all already used in one location, but have been
> vendored multiple times. We need to document each case, since it's not
> necessarily clear that each vendored version of the libraries are the
> same.
>
> It should be enough to just add a second @-line in the LICENSE file,
> so it's clear that the license applies to both versions.
>
> Three files are missing their Apache header in traffic_monitor/cache:
> - stats_type_astats.go
> - stats_type_astats_dsnames.go
> - stats_types.go
>
> On Tue, Feb 13, 2018 at 4:20 PM, Dave Neuman <neu...@apache.org> wrote:
> > Hey Jeff,
> > I can take a look at that PR.
> > Thanks,
> > Dave
> >
> > On Tue, Feb 13, 2018 at 4:15 PM, Jeff Elsloo <els...@apache.org> wrote:
> >
> >> I just submitted the following PR to resolve the issues stemming from
> >> PR 1720: https://github.com/apache/incubator-trafficcontrol/pull/1877
> >> --
> >> Thanks,
> >> Jeff
> >>
> >>
> >> On Tue, Feb 13, 2018 at 3:25 PM, Jeff Elsloo <els...@apache.org> wrote:
> >> > -1 due to the following PR breaking the Traffic Router build:
> >> > https://github.com/apache/incubator-trafficcontrol/pull/1720
> >> >
> >> > I'm looking into the issue now and hope to have it resolved soon.
> >> > --
> >> > Thanks,
> >> > Jeff
> >> >
> >> >
> >> > On Tue, Feb 13, 2018 at 11:56 AM, Robert Butts <r...@apache.org>
> wrote:
> >> >> Hello All,
> >> >>
> >> >> I've prepared a release for v2.2.0-RC0
> >> >>
> >> >> The vote is open for at least 72 hours and passes if a majority of at
> >> least
> >> >> 3 +1 PPMC votes are cast.
> >> >>
> >> >> [ ] +1 Approve the release
> >> >>
> >> >> [ ] -1 Do not release this package because ...
> >> >>
> >> >> Changes since 2.1.0:
> >> >> https://github.com/apache/incubator-trafficcontrol/
> >> compare/RELEASE-2.1.0...RELEASE-2.2.0-RC0
> >> >>
> >> >> This corresponds to git:
> >> >>  Hash: 9730e9a25e9e665a0873d2f2fb04c97491e60131
> >> >>  Tag: RELEASE-2.2.0-RC0
> >> >>
> >> >> Which can be verified with the following: git tag -v
> RELEASE-2.2.0-RC0
> >> >>
> >> >> My code signing key is available here:
> >> >> http://keys.gnupg.net/pks/lookup?search=0xFDD04F7F&op=vindex
> >> >>
> >> >> Make sure you refresh from a key server to get all relevant
> signatures.
> >> >>
> >> >> The source .tgz file, pgp signature (.asc signed with my key from
> >> >> above), md5 and sha1 checksums are provided here:
> >> >>
> >> >> https://dist.apache.org/repos/dist/dev/incubator/
> >> trafficcontrol/2.2.0/RC0/
> >> >>
> >> >> Thanks!
> >>
>

Reply via email to