[ 
https://issues.apache.org/jira/browse/TS-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775957#action_12775957
 ] 

Leif Hedstrom commented on TS-13:
---------------------------------

v4 worked fine on my 32-bit box, but  a few comments:

1) Can we restore the -g for the release build? -ggdb3 is extremely verbose, 
making all the binaries 3x as large.

2) If we're no incorporating the patches I did for -march= detection, I think 
we need to do what Andrew suggested, and change the order in configure.ac, e.g.

    CCFLAGS="-march=pentium $CCFLAGS"
    CXXFLAGS="-march=pentium $CXXFLAGS"

3) Finally, I did a test with -march=i486 with the v4 patch, and it does not 
work. So -march=pentium is a minimum. I think we should change this to 
-march=i586 though, it's more in-line with the naming conventions used by the 
distros.

I'm doing a second review of the actual code changes too, hopefully we can land 
this soon.

> x86_64 linux port
> -----------------
>
>                 Key: TS-13
>                 URL: https://issues.apache.org/jira/browse/TS-13
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Portability
>    Affects Versions: 2.0a
>         Environment: 64-bit linux (fedora 8 w/gcc 4.3.2)
>            Reporter: John Plevyak
>         Attachments: 0001-Properly-search-usr-lib64-for-tclConfig.sh.patch, 
> 0003-TS-13-Add-support-to-only-add-march-pentium-if-CFLAG.patch, 
> 64bit-bcall-001.patch, ts-64bit-v1.patch, ts-64bit-v2.patch, 
> ts-64bit-v3.patch, ts-64bit-v4.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Need to compile and run in x86_64 mode on 64-bit linux

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to