On 12/17/2009 01:15 AM, Mladen Turk wrote:
Hi,
The patch allows to set the hard coded 'nobody' user
to something that eventually exists on the box
(added --with-user and --with-group (defaults to --with-user)
to configure.
If not specified they default to 'nobody' as before
Not sure about naming since I'm not very clear for what that
user is used at the first place, so I didn't open the Jira directly.
Cool. These changes looks good, and I'd be ok to have this committed
(attach to the Jira though).
We do need to fix the following as well, preferably with this "bug", but
I'm ok fixing it later:
./proxy/config/records.config.in:CONFIG proxy.config.admin.user_id
STRING nobody
./proxy/mgmt2/cop/TrafficCop.cc:static char admin_user[80] = "nobody";
and not sure if we need / want this (also in TrafficCop.cc):
// bitch if the admin user is not "nobody"
if (strncmp("nobody", admin_user, sizeof(admin_user)) != 0) {
cop_log(COP_WARNING, "proxy.config.admin.user_id should be
\"nobody\"");
}
Cheers!
-- leif
