[ 
https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829939#action_12829939
 ] 

George Paul commented on TS-129:
--------------------------------

Code patch looks fine AFAICT. Tested patch and ran the simple DNS regression 
which passed. At some point simple regression tests for RR and splitDNS code 
paths should be added.

Could the BSD versions of the code for TS-44 functions be added in this patch 
since they are related to 'iocore/DNS.cc' changes. As is mentioned in that 
ticket there is BSD code for the necessary functions here:

 http://fxr.watson.org/fxr/source/nameser/ns_name.c?v=FREEBSD-LIBC
 http://fxr.watson.org/fxr/source/nameser/ns_netint.c?v=FREEBSD-LIBC

Also instead of pulling in ns_get16() could use the NS_GET16 macros in 
'ink_resolver.h'

-George

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch
>
>
> We have some BIND related code in TS, which we need to replace with something 
> that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, 
> lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to