[ 
https://issues.apache.org/jira/browse/TS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832330#action_12832330
 ] 

Bryan Call commented on TS-163:
-------------------------------

reviewed: patch looks good

I have a *very small* nit for a little cleaner code:

+  bool found;
+  RecInt stackDump;
+  found = (RecGetRecordInt("proxy.config.stack_dump_enabled", &stackDump) == 
REC_ERR_OKAY);

+  RecInt stackDump;
+  bool found = (RecGetRecordInt("proxy.config.stack_dump_enabled", &stackDump) 
== REC_ERR_OKAY);


> variable proxy.config.stack_dump_enabled, enabled by default is added to 
> enable / disable TS custom stack trace
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: TS-163
>                 URL: https://issues.apache.org/jira/browse/TS-163
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Wendy Huang
>            Priority: Minor
>         Attachments: TS-163.patch
>
>
> This is copied from bugzilla 3065494
> variable proxy.config.stack_dump_enabled(default: enabled) is added to enable 
> / disable TS custom
> stack trace
> Need to merge the change to ATS

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to