On 08/28/2010 04:34 PM, Igor Galić wrote:
Hi folks,

in discussing clang with zwoop on IRC, I ended up doing a port
this weekend. The progress is documented here:

https://issues.apache.org/jira/browse/TS-427

Very cool. I won't have time to look at this for the next week or so, due to "work issues", hopefully someone else can take a look at it ?



If this patchset is to be accepted, or even considered, it needs
review and testing with different compilers. I'm especially
suspect of (old versions of) VC++, thanks to certain comments
in the code.

That is a none issue I think, since we don't support Windows. The VC++ comments are legacy, and I wouldn't be too concerned about them (although, intentionally breaking it for no good reason would seem counter productive :). If (or when) someone decides to update the code to run on Windows, we can revisit), so maybe making a // TODO comment could also be useful for future developers.


Cheers!

-- leif

Reply via email to