On 04/22/2011 02:17 PM, Alan M. Carroll wrote:
You mean ink_res_sockaddr_union in ink_resolver.h? I just deleted that and 
changed all uses to sockaddr_storage. I think it's better to use a standard 
type rather than introducing yet another ATS local type. The accessibility it 
provided via union will be done by the ip_cast functions.

No, I actually meant this in HttpTransact.h:

    struct sockaddr_storage addr;


that is (afaik) used for the IPv6 client side implementation.
My general view is, keep everything as a sockaddr_storage until you actually 
need to extract something, then do that as locally as possible. There's little 
point in extracting an IPv4 addr, passing it off, then putting it back in a 
sockaddr_in which is cast to a

Yep.

-- Leif

Reply via email to