So from what I can tell, the frequent_accept deal was not for TS-876, it
was for TS-919, in the following commit:
http://svn.apache.org/viewvc?view=revision&revision=1159655. So the fix he
committed for TS-876 was in UrlRewrite.cc and was a missing constructor
initialization. So I'll submit a new patch that doesn't merge the fixes for
two different bugs and add it back into STATUS.

So since all the correct code is already in trunk for TS-876 should I just
leave a note in STATUS that points to the Jira for the correct patch?

Brian

2012/1/27 Igor Galić <i.ga...@brainsware.org>

>
>
> ----- Original Message -----
> > On 01/27/2012 02:04 AM, Igor Galić wrote:
> > >
> > > This one changes frequent_accept from a default of true to false
> > > which
> > > is one of the things that gave amc so much headache over TS-1077,
> > > so I'm
> > > a little ambivalent.
> > >
> > >
> >
> > Yes. Unless the logic around the accept code is also modified,
> > changing
> > frequent_accept from true to false is bad mojo (it would disable
> > multiple accept threads for example, and never allow accept on the
> > net-threads).
>
> ACK.
>
> Brian, can you fix this up and propose your own patch?
>
> > -- leif
>
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.ga...@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE
>
>

Reply via email to