[snip] > > Another side note: Has anyone considered borrowing httpd's idea of > > uniquely numbering each error log message? > > That's a great idea ... how do they manage automation of message > number assignments? Please see:
https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/log-message-tags [snip] > > +SSLDebugBufferPrint(const char * tag, const char * buffer, > > unsigned buflen, const char * message) > > + for (unsigned ii = 0; ii < buflen; ii++) { > > + putc(buffer[ii], stdout); > > + } > > + putc('\n', stdout); > > why do we use putc here? > > I really don't know ... that code was there before me. I guess I should take a look at SSLUtils.cc separately then [snip] > > + // On Darwin, fail the tests if we have any memory leaks. > > +#if defined(darwin) > > + if (system("xcrun leaks test_certlookup") != 0) { > > + RegressionTest::final_status = REGRESSION_TEST_FAILED; > > + } > > +#endif > > > > Wouldn't it be a good idea to do this in general? > > Yes it would be good to do it in general, but this was a tiny hack to > let me test. > > > i.e.: Use valgrind (or which ever tool) on the regression test suit > > if it's available and/or enabled, i.e.: If we --enable-debug && > > --enable-tests > > Yes, for valgrind you would have to enable this at build time and > integrate it into the test harness system. I don't know how long > it's been since anyone has valgrind'd ATS so there's a probably a > bit of work involved in making is clean. Any takers for this little project? > Thanks for taking the time to review ... > > J i -- Igor Galić Tel: +43 (0) 664 886 22 883 Mail: i.ga...@brainsware.org URL: http://brainsware.org/ GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
