----- Original Message -----
> Updated Branches:
> refs/heads/master b2bacd7ad -> f0b3b864a
>
>
> TS-1738 stats: missing "proxy.cluster.cache_total_hits_mem" in
> RecordsConfig
>
> 1. we had defined "proxy.node.cache_total_hits_mem", a corresponding
> clsuter
> record should be defined.
>
> 2. "proxy.cluster.cache_total_hits_mem" are using in stats.config.xml
> file,
> missing definition will cause unexpected result.
>
> BTW: fix weird tailling spaces by my VIM automatically.
>
> Signed-off-by: Yunkai Zhang <qiushu....@taobao.com>
> Signed-off-by: Zhao Yongming <ming....@gmail.com>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/f0b3b864
> Tree:
> http://git-wip-us.apache.org/repos/asf/trafficserver/tree/f0b3b864
> Diff:
> http://git-wip-us.apache.org/repos/asf/trafficserver/diff/f0b3b864
>
> Branch: refs/heads/master
> Commit: f0b3b864ad2d50a6f33da884de7cea75ec599453
> Parents: b2bacd7
> Author: Yunkai Zhang <qiushu....@taobao.com>
> Authored: Fri Mar 1 11:23:23 2013 +0800
> Committer: Zhao Yongming <ming....@gmail.com>
> Committed: Sat Mar 2 21:22:09 2013 -0800
>
> ----------------------------------------------------------------------
> CHANGES | 3 +++
> mgmt/RecordsConfig.cc | 8 +++++---
> 2 files changed, 8 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f0b3b864/CHANGES
> ----------------------------------------------------------------------
> diff --git a/CHANGES b/CHANGES
> index 9b29ff7..0af8634 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -1,6 +1,9 @@
> -*- coding:
> utf-8 -*-
> Changes with Apache Traffic Server 3.3.1
>
> + *) [TS-1738] proxy.cluster.cache_total_hits_mem is missing in
> RecordsConfig
> + Author: Yunkai Zhang <qiushu....@taobao.com>
> +
> *) [TS-1739] Fix TODO within varFloatFromName()
> Author: Yunkai Zhang <qiushu....@taobao.com>
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f0b3b864/mgmt/RecordsConfig.cc
> ----------------------------------------------------------------------
> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
> index f731944..47f6395 100644
> --- a/mgmt/RecordsConfig.cc
> +++ b/mgmt/RecordsConfig.cc
> @@ -1025,9 +1025,9 @@ RecordElement RecordsConfig[] = {
> ,
> {RECT_CONFIG, "proxy.config.dns.nameservers", RECD_STRING, NULL,
> RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> ,
> - {RECT_CONFIG, "proxy.config.dns.local_ipv6", RECD_STRING, NULL,
> RECU_RESTART_TS, RR_NULL, RECC_STR, NULL, RECA_NULL}
> + {RECT_CONFIG, "proxy.config.dns.local_ipv6", RECD_STRING, NULL,
> RECU_RESTART_TS, RR_NULL, RECC_STR, NULL, RECA_NULL}
> ,
> - {RECT_CONFIG, "proxy.config.dns.local_ipv4", RECD_STRING, NULL,
> RECU_RESTART_TS, RR_NULL, RECC_STR, NULL, RECA_NULL}
> + {RECT_CONFIG, "proxy.config.dns.local_ipv4", RECD_STRING, NULL,
> RECU_RESTART_TS, RR_NULL, RECC_STR, NULL, RECA_NULL}
> ,
> {RECT_CONFIG, "proxy.config.dns.resolv_conf", RECD_STRING,
> "/etc/resolv.conf", RECU_RESTART_TS, RR_NULL, RECC_NULL, NULL,
> RECA_NULL}
> ,
> @@ -1035,7 +1035,7 @@ RecordElement RecordsConfig[] = {
> ,
> {RECT_CONFIG, "proxy.config.dns.dedicated_thread", RECD_INT, "0",
> RECU_RESTART_TS, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
> ,
> - {RECT_CONFIG, "proxy.config.hostdb.ip_resolve", RECD_STRING, NULL,
> RECU_RESTART_TS, RR_NULL, RECC_STR, NULL, RECA_NULL}
> + {RECT_CONFIG, "proxy.config.hostdb.ip_resolve", RECD_STRING, NULL,
> RECU_RESTART_TS, RR_NULL, RECC_STR, NULL, RECA_NULL}
> ,
Took me a while to realize that the first part is a space-only change.
>
> //##############################################################################
> @@ -1809,6 +1809,8 @@ RecordElement RecordsConfig[] = {
> ,
> {RECT_CLUSTER, "proxy.cluster.cache_total_hits", RECD_INT, "0",
> RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> ,
> + {RECT_CLUSTER, "proxy.cluster.cache_total_hits_mem", RECD_INT,
> "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> + ,
> {RECT_CLUSTER, "proxy.cluster.cache_total_misses", RECD_INT, "0",
> RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> ,
> {RECT_CLUSTER, "proxy.cluster.current_cache_connections",
> RECD_INT, "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
Thanks a lot for this catch
-- i
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.ga...@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
