On 5/11/13 1:24 PM, James Peach wrote:
On May 11, 2013, at 7:38 AM, Leif Hedstrom <[email protected]> wrote:
On 5/10/13 11:40 PM, [email protected] wrote:
TS-1889: refactor remap plugin request URL handling
For (apparantly) historical reasons, the remap plugin support
to diverge due to the presence of a remap plugin.
This also changes the behavior of the chaining of plugins, as we discussed,
right?
No, I fixed that bug before committing. There should be no change on behaviour.
Ack.
I think it's worthwhile to add a note to the "Upgrade to v3.4" section on the wiki here,
and also send something to users@ and dev@ ? The changes are good, but could potentially break some
chaining of remap plugins if they depend on the old behavior of always applying the
"ToUrl" between invocation of remap plugins when the previous one did not modify the
request URL.
I'd like to make this change in a separate commit. The new behaviour would be
to not apply the ToUrl until after all plugins have been invoked. If a plugin
rewrites the request URL, then the default rewrite would never take place.
+1.
-- Leif
