Any objections ?
Begin forwarded message: > From: "Leif Hedstrom (JIRA)" <j...@apache.org> > Date: August 27, 2013, 6:26:51 PM PDT > To: zw...@apache.org > Subject: [jira] [Created] (TS-2163) Remove WDA_BILLING, ACC_ALARMS etc. code > and definitions > > Leif Hedstrom created TS-2163: > --------------------------------- > > Summary: Remove WDA_BILLING, ACC_ALARMS etc. code and definitions > Key: TS-2163 > URL: https://issues.apache.org/jira/browse/TS-2163 > Project: Traffic Server > Issue Type: Improvement > Components: TS API > Reporter: Leif Hedstrom > > > These defines and API was designed for a specific Inktomi customer, which > asked for their own set of alarms for their plugin. This is useless IMO, and > we should remove it. IF long term we want extensible alarm codes, a different > solution should be put in place (one where plugins can register alarms and > alarms definitions). > > Please voice your objections to this if you feel that these should stay: > > {code} > -#define REC_ALARM_WDA_BILLING_CONNECTION_DIED 100 > -#define REC_ALARM_WDA_BILLING_CORRUPTED_DATA 101 > -#define REC_ALARM_WDA_XF_ENGINE_DOWN 102 > -#define REC_ALARM_WDA_RADIUS_CORRUPTED_PACKETS 103 > - > -#define REC_ALARM_ACC_ALARMS_START 200 > -#define REC_ALARM_ACC_ALARMS_END 299 > {code} > > and from ts/experimental.h (oxygen was the Inktomi customer I think): > > {code} > - typedef enum > - { > - TS_SIGNAL_WDA_BILLING_CONNECTION_DIED = 100, > - TS_SIGNAL_WDA_BILLING_CORRUPTED_DATA = 101, > - TS_SIGNAL_WDA_XF_ENGINE_DOWN = 102, > - TS_SIGNAL_WDA_RADIUS_CORRUPTED_PACKETS = 103 > - } TSAlarmType; > - > - /* ===== Alarm ===== */ > - > /**************************************************************************** > - * ?? > - * contact: OXYGEN > - > ****************************************************************************/ > - tsapi void TSSignalWarning(TSAlarmType code, char *msg); > {code} > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira
