On Sep 10, 2013, at 11:18 PM, Yongming Zhao <ming....@gmail.com> wrote:

> 
> INT
> 
> 1
> 
> 
> When disabled(0), do nothing.
> When enabled (1), Traffic Server inserts Client-IP headers to retain the 
> client IP address, if there is no such headers.  
> When forced (2), Traffic Server inserts Client-IP, or replace the origin 
> Client-IP header if it is already there.


+1. I always found these confusing, in fact, I find all the ones where we have 
an "enable" and a "value" duo of configs to be unnecessarily confusing.

The only caveat here is that you will need to support all three configs for 4.x 
:-).  Key is that any new behavior acts as the old one "by default", 
particularly in the case of using an "old" records.config.

Also, and this is for everyone, make sure to update Docs when adding features, 
and also (for now at least) update the Wiki page so we know What's New. I've 
created a new section on the Wiki:

        
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34020337


Under there we now have two pages, What's new in v4.0.0 (this is completed, 
don't add to it), and the upcoming "What's new in v4.1.0". New features / 
config / APIs should be added here as well as to the normal Docs (at least 
until/if we figure out how to manage this entirely in Sphinx).

Cheers,

-- Leif

Reply via email to