Re: git commit: TS-2420: Remove STAT_SYNC, CONF_SYNC, and REM_SYNC threads and schedule those continuations in ET_TASK

[Leif Hedstrom]

On Dec 5, 2013, at 8:25 PM, sor...@apache.org wrote:

> Updated Branches:
>  refs/heads/master 354fbc267 -> 853722820
> 
> 
> TS-2420: Remove STAT_SYNC, CONF_SYNC, and REM_SYNC threads and schedule
> those continuations in ET_TASK



I think with this, we should make the proxy.config.task_threads be a minimum of 
1. E.g.

diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
index a54e018..ca805db 100644
--- a/mgmt/RecordsConfig.cc
+++ b/mgmt/RecordsConfig.cc
@@ -114,7 +114,7 @@ RecordElement RecordsConfig[] = {
   ,
   {RECT_CONFIG, "proxy.config.accept_threads", RECD_INT, "1", RECU_RESTART_TS, 
RR_NULL, RECC_INT, "[0-1]", RECA_READ_ONLY}
   ,
-  {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2", RECU_RESTART_TS, 
RR_NULL, RECC_INT, "[0-99999]", RECA_READ_ONLY}
+  {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2", RECU_RESTART_TS, 
RR_NULL, RECC_INT, "[1-99999]", RECA_READ_ONLY}
   ,
   {RECT_CONFIG, "proxy.config.thread.default.stacksize", RECD_INT, "1048576", 
RECU_RESTART_TS, RR_NULL, RECC_INT, "[131072-104857600]", RECA_READ_ONLY}
   ,



Granted, I don’t think we do much (anything?) with the validations right now, 
but we should :).

— Leif