Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/107#issuecomment-54638343 This patch looks fine. Since this is an API change, it needs to got through API review before I can pull it. Once comment that I'll make in API review will be to ask whether ``rolling_size_mb`` can be unsigned. https://cwiki.apache.org/confluence/display/TS/API+Review+Process
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---