> On Feb 26, 2015, at 7:58 PM, Susan Hinrichs > <[email protected]> wrote: > > Originally proxy.process.ssl.total_success_handshake_count was a raw stat. > > We want to rename it to proxy.process.ssl.total_success_handshake_count_in > since we are adding proxy.process.ssl.total_handshake_success_count_out. > > So on attempt 1, I renamed the raw stat to > proxy.process.ssl.total_success_handshake_count_in, and I added > proxy.process.ssl.total_success_handshake_count to stats.config.xml.default > as a composite (probably not the right term) of > proxy.process.ssl.total_success_handshake_count. > > traffic_server was upset because the type of > proxy.process.total_success_handshake_count had changed.
In what way was it upset? > Open to suggestions for a better way of dealing with this kind of naming > update. > > On 2/26/2015 9:24 PM, James Peach wrote: >>> On Feb 26, 2015, at 1:15 PM, [email protected] wrote: >>> >>> Repository: trafficserver >>> Updated Branches: >>> refs/heads/master 4ab0ea32b -> 115eabd1e >>> >>> >>> TS-3409: Adjust new and old metric names to avoid corrupting existing >>> *.snap files. >> How does changing metric names corrupt the snap files? Is this fixable in >> librecords without these renaming shenanigans? >> >>> >>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo >>> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/115eabd1 >>> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/115eabd1 >>> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/115eabd1 >>> >>> Branch: refs/heads/master >>> Commit: 115eabd1e8b728e1e2a3bd14ec04a3fdef0741e2 >>> Parents: 4ab0ea3 >>> Author: shinrich <[email protected]> >>> Authored: Thu Feb 26 15:14:22 2015 -0600 >>> Committer: shinrich <[email protected]> >>> Committed: Thu Feb 26 15:14:22 2015 -0600 >>> >>> ---------------------------------------------------------------------- >>> iocore/net/SSLUtils.cc | 2 +- >>> mgmt/RecordsConfig.cc | 2 +- >>> proxy/config/stats.config.xml.default | 4 ++-- >>> 3 files changed, 4 insertions(+), 4 deletions(-) >>> ---------------------------------------------------------------------- >>> >>> >>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/115eabd1/iocore/net/SSLUtils.cc >>> ---------------------------------------------------------------------- >>> diff --git a/iocore/net/SSLUtils.cc b/iocore/net/SSLUtils.cc >>> index 410915e..361d344 100644 >>> --- a/iocore/net/SSLUtils.cc >>> +++ b/iocore/net/SSLUtils.cc >>> @@ -908,7 +908,7 @@ SSLInitializeStatistics() >>> RecRegisterRawStat(ssl_rsb, RECT_PROCESS, >>> "proxy.process.ssl.total_handshake_time", >>> RECD_INT, RECP_PERSISTENT, (int) >>> ssl_total_handshake_time_stat, >>> RecRawStatSyncSum); >>> - RecRegisterRawStat(ssl_rsb, RECT_PROCESS, >>> "proxy.process.ssl.total_success_handshake_count_in", >>> + RecRegisterRawStat(ssl_rsb, RECT_PROCESS, >>> "proxy.process.ssl.total_success_handshake_count", >>> RECD_INT, RECP_PERSISTENT, (int) >>> ssl_total_success_handshake_count_in_stat, >>> RecRawStatSyncCount); >>> RecRegisterRawStat(ssl_rsb, RECT_PROCESS, >>> "proxy.process.ssl.total_success_handshake_count_out", >>> >>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/115eabd1/mgmt/RecordsConfig.cc >>> ---------------------------------------------------------------------- >>> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc >>> index 75cc5a8..7a3ba34 100644 >>> --- a/mgmt/RecordsConfig.cc >>> +++ b/mgmt/RecordsConfig.cc >>> @@ -1800,7 +1800,7 @@ static const RecordElement RecordsConfig[] = >>> , >>> >>> >>> - {RECT_NODE, "proxy.process.ssl.total_success_handshake_count", RECD_INT, >>> "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL} >>> + {RECT_NODE, "proxy.process.ssl.total_success_handshake_count_in", >>> RECD_INT, "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL} >>> , >>> >>> //# >>> >>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/115eabd1/proxy/config/stats.config.xml.default >>> ---------------------------------------------------------------------- >>> diff --git a/proxy/config/stats.config.xml.default >>> b/proxy/config/stats.config.xml.default >>> index 507ba9f..430e2be 100644 >>> --- a/proxy/config/stats.config.xml.default >>> +++ b/proxy/config/stats.config.xml.default >>> @@ -1948,9 +1948,9 @@ >>> >>> <statistics >>> minimum="0"> >>> - >>> <destination>proxy.process.ssl.total_success_handshake_count</destination> >>> + >>> <destination>proxy.process.ssl.total_success_handshake_count_in</destination> >>> <expression> >>> - proxy.process.ssl.total_success_handshake_count_in >>> + proxy.process.ssl.total_success_handshake_count >>> </expression> >>> </statistics> >>> >>> >
