Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/181#discussion_r26590946
--- Diff: plugins/experimental/buffer_upload/buffer_upload.cc ---
@@ -753,6 +753,15 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */,
TSEvent event, void *edata)
memcpy(replacement_host_str, host_hdr_str_val,
host_hdr_str_val_len);
TSDebug(DEBUG_TAG, "Adding host to request url: %s",
replacement_host_str);
+ const char *colon = strchr(replacement_host_str, ':');
+ if (colon != NULL && colon + 1 != NULL) {
+ int port_str_val = atoi(colon + 1);
+
+ if (port_str_val != 80) {
--- End diff --
Why only check for port 80 and not 443? Also, you should consider checking
the scheme.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
