Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/284#discussion_r38252920
--- Diff: plugins/header_rewrite/conditions.cc ---
@@ -237,13 +236,22 @@ ConditionHeader::append_value(std::string &s, const
Resources &res)
}
if (bufp && hdr_loc) {
+ TSMLoc field_loc, next_field_loc;
+
field_loc = TSMimeHdrFieldFind(bufp, hdr_loc, _qualifier.c_str(),
_qualifier.size());
TSDebug(PLUGIN_NAME, "Getting Header: %s, field_loc: %p",
_qualifier.c_str(), field_loc);
- if (field_loc != NULL) {
+
+ while (field_loc) {
value = TSMimeHdrFieldValueStringGet(bufp, hdr_loc, field_loc, -1,
&len);
+ next_field_loc = TSMimeHdrFieldNextDup(res.bufp, res.hdr_loc,
field_loc);
TSDebug(PLUGIN_NAME, "Appending HEADER(%s) to evaluation value ->
%.*s", _qualifier.c_str(), len, value);
s.append(value, len);
+ // multiple headers with the same name must be symantically the same
as one value which is comma seperated
(http://tools.ietf.org/html/rfc2616#section-4.2)
--- End diff --
*semantically*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
