GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/322
TS-306: Fix file privilege elevation to work with log rotation.
This fixes several issues.
The biggest is DAC bypass privilege elevation. Because `traffic_server` is
invoked in multiple ways (full deployment, standalone, via `gdb`, etc.)
sometimes the process is privileged when the logfiles are bound and sometimes
it is not. The existing elevation mechanism does not work if the process is
already privileged because it incorrectly removes the privileges when it lowers
privileges. I have changed this to save the current capability set and restore
it on lowering so that it works in both cases.
I tweaked the buffering on the logfiles to avoid log messages apparently
stopping in the middle.
I changed an argument naming to reserve leading underscores for class
member variables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-306
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit a69b103bdd34c1287e83439f154cced5877f3fe1
Author: Alan M. Carroll <a...@apache.org>
Date: 2015-11-04T23:54:23Z
TS-306: Fix file privilege elevation to work with log rotation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
