Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/455#issuecomment-181604662 Yeah, the problem with it (and pretty much all of STL) is that it has hidden (and sometimes) unpredictable memory allocations behavior. I did some tests recently with bcall, where different compilers does different things when passing strings as argument to a function (one copied the string, the other did not). I'm ok with std::string inside the if(debug tag) if you insist. My preference would be not to use std::string unless absolutely necessary (because it sets bad precedence), but it's difficult to make a strong argument here against it. :-).
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---