Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/490#issuecomment-186950232
  
    This looks generally reasonable.
    
    I'd like the patch series to be a bit cleaner; maybe fix the vagrant box 
URLs in the first commit, then switch over to the shell provisioner.
    
    We need to retain the additional build packages (``libcap-devel``, etc) so 
that optional components are always detected and built. It looks like you 
dropped FreeBSD, was that deliberate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to