Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56909414
--- Diff: proxy/http2/HPACK.h ---
@@ -90,31 +97,29 @@ class MIMEFieldWrapper
return _field;
}
+ bool
+ is_sensitive() const
+ {
+ return _field->is_sensitive();
+ }
+
private:
MIMEField *_field;
HdrHeap *_heap;
MIMEHdrImpl *_mh;
};
-// Result of looking for a header field in IndexingTable
-struct Http2LookupIndexResult {
- Http2LookupIndexResult() : index(0), value_is_indexed(false) {}
-
- int index;
- bool value_is_indexed;
-};
-
// [RFC 7541] 2.3.2. Dynamic Table
-class Http2DynamicTable
+class HpackDynamicTable
{
public:
- Http2DynamicTable() : _current_size(0),
_settings_dynamic_table_size(4096)
+ HpackDynamicTable() : _current_size(0), _maximum_size(4096)
--- End diff --
4096 should a constant in HPACK.h
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
