> On Apr 22, 2016, at 7:28 PM, Chao Xu <[email protected]> wrote:
>
> As a proxy, there has two side: client side ( Client <-> Proxy ) and server
> side ( Proxy <-> Server ).
Each side would be a separate NetVConnection.
> Add a new member 'netvc_context' into class NetVConnection to indicate
> which side the NetVC working on.
>
> And remove member 'server_addr' from UnixNetVConnection:
>
> {code}
> 246 // amc - what is this for? Why not use remote_addr or con.addr?
> 247 IpEndpoint server_addr; /// Server address and port.
> {code}
It looks to me that “server_addr” is set when you connect(2) an outbound vc. I
think I agree with Alan’s comment that this should probably be
get_remote_addr().
> implement new methods get_client_addr() and get_server_addr() on
> NetVConnection to instead server_addr. these two methods could get the
> right server/client address value by get_local_addr() or get_remote_addr()
> depend on netvc_context.
What problem is this solving? I can see that it would work, but would it
noticeably clarify anything?
J
