Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/606#issuecomment-215619566 The 4th commit is so much refactoring with no change in behavior that it's hard to follow what the actual fix is. I agree that `r` is a poor variable name, and a lot of the other changes do make the code clearer. Would be nice to separate them out as you did in the other commits.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---