Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219936052
@SolidWallOfCode get_server_addr() and get_client_addr() is wrapper
functions only.
the wrapper function get_server_addr() is used to decide which variables
should be used here.
for example ( iocore/net/SSLClientUtils.cc ):
```
85 // Otherwise match by IP
86 else {
87 char buff[INET6_ADDRSTRLEN];
88 ats_ip_ntop(netvc->server_addr, buff, INET6_ADDRSTRLEN);
89 if (validate_hostname(cert, reinterpret_cast<unsigned char
*>(buff), true, NULL)) {
90 SSLDebug("IP %s verified OK", buff);
91 return preverify_ok;
92 }
93 SSLDebug("IP verification failed for (%s)", buff);
94 }
```
directly replace server_addr with get_local_addr() or get_remote_addr()
```
if (netvc->get_context() == NetVConnection_C2P) {
ats_ip_ntop(netvc->get_local_addr(), buff, INET6_ADDRSTRLEN);
} else {
ats_ip_ntop(netvc->get_remote_addr(), buff, INET6_ADDRSTRLEN);
}
```
replace server_addr with get_server_addr()
```
ats_ip_ntop(netvc->get_server_addr(), buff, INET6_ADDRSTRLEN);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
