Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/669#discussion_r64783870
--- Diff: proxy/http/Http1ClientSession.cc ---
@@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction
*trans)
ka_vio = this->do_io_read(this, INT64_MAX, read_buffer);
ink_assert(slave_ka_vio != ka_vio);
- // Y!?
- // client_vc->add_to_keep_alive_lru();
- client_vc->cancel_active_timeout();
+ if (client_vc) {
+ client_vc->add_to_keep_alive_queue();
+ if (client_vc) {
--- End diff --
Susan had to explain this to me because I'm kind of slow but I think it
might be good to have a comment about why `client_vc` needs to be checked again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
