Github user calavera commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/688#discussion_r65460866
--- Diff: proxy/http/HttpSM.cc ---
@@ -2439,8 +2439,12 @@ HttpSM::state_cache_open_write(int event, void *data)
if (ua_session) {
NetVConnection *vc = ua_session->get_netvc();
if (vc && vc->thread != this_ethread()) {
- pending_action = vc->thread->schedule_imm(this, event, data); //
Stay on the same thread!
- return 0;
+ if (vc->thread->is_event_type(ET_NET) ||
vc->thread->is_event_type(SSLNetProcessor::ET_SSL)) {
+ pending_action = vc->thread->schedule_imm(this, EVENT_INTERVAL);
--- End diff --
it looks like it will crash if you change the event there because the
switch below won't ever get a valid even, won't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
