Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66984304
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1089,7 +1091,7 @@ static const RecordElement RecordsConfig[] =
{RECT_CONFIG, "proxy.config.hostdb.timed_round_robin", RECD_INT, "0",
RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
,
// # how often should the hostdb be synced (seconds)
- {RECT_CONFIG, "proxy.config.cache.hostdb.sync_frequency", RECD_INT,
"120", RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ {RECT_CONFIG, "proxy.config.cache.hostdb.sync_frequency", RECD_INT,
"120", RECU_RESTART_TS, RR_NULL, RECC_NULL, NULL, RECA_NULL}
--- End diff --
This wasn't dynamic to begin with (even though it said otherwise). I do
agree it'd be good to make dynamic-- so I'll open a ticket to followup on that
(https://issues.apache.org/jira/browse/TS-4540), but I don't plan on getting
that for this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
