Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/717#discussion_r68081721
--- Diff: proxy/http/Http1ClientSession.h ---
@@ -181,7 +189,12 @@ class Http1ClientSession : public ProxyClientSession
MIOBuffer *read_buffer;
IOBufferReader *sm_reader;
- C_Read_State read_state;
+
+ /*
+ * Volatile should not be necessary, but there appears to be a bug in
the 4.9 rhel gcc
+ * compiler that was using an old version of read_state to make
decisions in really_destroy
+ */
+ volatile C_Read_State read_state;
--- End diff --
If there are threaded dependencies on this, then we should force an atomic
read or a memory acquire/release. I think the volatile is too subtle to be
depended on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
