Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/736#discussion_r68513514
  
    --- Diff: proxy/InkAPI.cc ---
    @@ -8941,3 +8942,110 @@ TSVConnReenable(TSVConn vconn)
         }
       }
     }
    +
    +// APIs for managing and using UUIDs.
    +TSUuid
    +TSUuidCreate(void)
    +{
    +  ATSUuid *uuid = new ATSUuid();
    +  return (TSUuid)uuid;
    +}
    +
    +TSReturnCode
    +TSUuidDestroy(TSUuid uuid)
    +{
    +  sdk_assert(sdk_sanity_check_null_ptr((void *)uuid) == TS_SUCCESS);
    +  ATSUuid *u = (ATSUuid *)uuid;
    +
    +  if (u->alive()) {
    --- End diff --
    
    It used to do more, but not it just does a poor amount of sanity check, and 
it certainly can not be a guarantee. It could not be a false negative though. 
It'd probably make more sense if the data was on a freelist, maybe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to