Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/788
Hmmm, this code looks overly complicated already to begin with :-/. Why is
RefCountCacheSerializer a template class? It's tightly coupled with HostDB it
seems, and is only used to contain HostDBInfo?
If we are going to clean this up, I'd strongly suggest not using templates
just because. I know this isn't your fault James (in any way), and you are
trying to make it better, but this is not good.
That much said, I'm ok with the refactoring, it's making it a bit better
(but I still don't like this :). As someone smart said, this is premature
generalization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
