> On Oct 16, 2016, at 9:18 AM, Leif Hedstrom <zw...@apache.org> wrote:
> I'll try to review next week, but I'm +1 on the concept. I assume we have 
> places were we use 0 but really should use nullptr?

The only weird think I found is that we used NULL for an invalid pthread_t 
(which is an integral type in glibc). I added ink_thread_null() to capture the 
platform-specific value for this (pretty sure 0 is never a valid pthread_t on 
any platform).

> -- Leif 
>> On Oct 16, 2016, at 9:15 AM, James Peach <jpe...@apache.org> wrote:
>> Hi all,
>> I’ve posted a RFC pull request 
>> <https://github.com/apache/trafficserver/pull/1112> that converts all uses 
>> of NULL to nullptr. The primary motivation for this is that there are 
>> circumstances (primarily template usage) where nullptr is required to detect 
>> the difference between a null pointer and a integer 0.
>> thanks,
>> James

Reply via email to