> On Jan 17, 2018, at 4:15 AM, Phil Sorber <sor...@apache.org> wrote:
> 
> We haven't made changes that enable clustering, but I believe this is a
> large change and seems like a bad idea in a minor release. If I were the RM
> I'd -1 it, but since I am not, I'll just express my concern.



I agree that it’s slightly sketchy, but I think the upsides as noticeable 
(easier to cherry-pick from master to 7.1.x branch). Also, I believe this PR is 
a cherry-pick + fixes from master to the 7.1.x branch? If so, please make sure 
the cherry pick(s) are done with “cherry-pick -x”.

I was contemplating if this would be better for a 7.2.x release, but alas, that 
forces us into supporting both 7.1.x and 7.2.x for a while. But, if you guys 
have other feature changes queued up for 7.x, that need to go into a 7.2.x 
release, then that would be the better choice here.

Cheers,

— Leif

Reply via email to