> On Aug 30, 2020, at 19:48, Masakazu Kitajo <mas...@apache.org> wrote:
>
> I think we should avoid adding APIs just for HTTP/2 unless it's really
> HTTP/2 specific. Are we going to add TSHttpTxnClientHttp3StreamIdGet and
> TSHttpTxnClientHttp3PriorityGet as well?
>
> I'd omit the "2" in the API names, and rephrase the API doc like:
> This API returns an error if the provided transaction does not have a
> stream id.
>
> Also, a stream id on HTTP/3 (QUIC) is 62 bit integer.
+1. Lets make a continued effort to have as few APIs as possible. If needed,
passing along a protocol identifier would be preferable, such that one API for
all “streams” capable protocols can use the same API.
— Leif
>
> Masakazu
>
>
>> On Sat, Aug 29, 2020 at 5:24 AM SUSAN HINRICHS <shinr...@ieee.org> wrote:
>>
>> +1
>>
>> On Fri, Aug 28, 2020 at 3:23 PM Sudheer Vinukonda
>> <sudheervinuko...@yahoo.com.invalid> wrote:
>>
>>> +1.
>>> Sounds reasonable to me.
>>>
>>>
>>> On Friday, August 28, 2020, 07:41:18 AM PDT, Brian Neradt <
>>> brian.ner...@gmail.com> wrote:
>>>
>>> Hi dev@trafficserver.apache.org,
>>>
>>> It would be helpful to add HTTP/2 stream and priority support to Traffic
>>> Dump. In order for the plugin to access this information, I propose
>> adding
>>> the following two functions to the TS API:
>>>
>>> tsapi TSReturnCode TSHttpTxnClientHttp2StreamIdGet(TSHttpTxn txnp,
>> uint32_t
>>> *stream_id);
>>>
>>> tsapi TSReturnCode TSHttpTxnClientHttp2PriorityGet(TSHttpTxn txnp, int
>>> *stream_dependency, int *weight);
>>>
>>> I've created a draft PR with this implemented along with Traffic Dump's
>> use
>>> of it:
>>> https://github.com/apache/trafficserver/pull/7149
>>>
>>> Please let me know if there are any concerns or suggestions for
>> improvement
>>> concerning this.
>>>
>>> Thanks!
>>> Brian
>>>
>>> --
>>> "Come to Me, all who are weary and heavy-laden, and I will
>>> give you rest. Take My yoke upon you and learn from Me, for
>>> I am gentle and humble in heart, and you will find rest for
>>> your souls. For My yoke is easy and My burden is light."
>>>
>>> ~ Matthew 11:28-30
>>>
>>
