> On Sep 6, 2023, at 4:26 PM, SUSAN HINRICHS <shinr...@ieee.org.INVALID> wrote:
>
> I would like to add a convenience API to fetch the file descriptor from a
> VConn object. I came across the need for this when writing a plugin
> working with a SSL VConn. For a variety of reasons, I didn't want the
> plugin to link with a ssl library. With this API, I could avoid pulling in
> the ssl library.
>
> PR with the proposed implementation
> https://github.com/apache/trafficserver/pull/10324
+1 (with Maskit’s suggestions on generalization)
This seems reasonable, and inline with the existing APIs. I assume we need this
for the VConn for cases where we don’t have a Txnp?. The existing API for Txpn
is slightly different, but looking at other VConn APIs, your proposal is inline
with those. Which is to return the FD directly, and not a TSReturnCode as
TSHttpTxnClientFdGet() does.
Cheers,
— Leif
>
> Proposed signature
> int TSVConnFdGet(TSVConn vconnp)
>
> Please let me know if you have any comments or concerns.
>
> Susan
