yes, the first call to getAtttibutes with entry value of 1 is leftover obsolete 
code.
It could be removed.
thanks for finding it.

anoop


-----Original Message-----
From: Zhu, Wen-Jun <[email protected]> 
Sent: Thursday, March 8, 2018 2:16 AM
To: [email protected]
Subject: a redundant statement?

Hi,

When I read the function AssignColEntry in file 
core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp, I find that there are two 
cliInterface->getAttributes():

cliRC = cliInterface->getAttributes(1, TRUE, fsDatatype, length,
                                    &indOffset, &varOffset);

cliRC = cliInterface->getAttributes(entry, TRUE, fsDatatype, length,
                                    &indOffset, &varOffset);

The output parameters and return value in first invocation are overwritten by 
the second one.

So I guess, is the fist invocation redundant?

Regards,
Wenjun Zhu

Reply via email to