Thanks @Dave Birdsall for taking care of this. I have added new comments for https://github.com/apache/trafodion/pull/1694 and requested for more info for https://github.com/apache/trafodion/pull/1603
It is better to wait for author to make changes as per the comments or respond before the PR is merged. Selva -----Original Message----- From: Dave Birdsall <[email protected]> Sent: Wednesday, December 19, 2018 6:18 PM To: [email protected]; [email protected] Subject: RE: Someone could help to review and merge code External Hi, I took a quick look at these. Regarding [TRAFODION-3246] support TLS for jdbc, https://github.com/apache/trafodion/pull/1765: I'm hoping someone qualified will review it soon. Regarding [TRAFODION-3250] optimize get/set schema, https://github.com/apache/trafodion/pull/1764: It looks like the JDBC tests have failed. You need to take a look to see why. I took a quick look and it doesn't seem to be an environmental failure. It looks like someone has approved the changes, though. Regarding [TRAFODION-3247] support customer define client charset, https://github.com/apache/trafodion/pull/1760: I merged it just now. Regarding [TRAFODION-3183] fetch huge data give rise to core, https://github.com/apache/trafodion/pull/1694: It wasn't clear to me if the reviewer approved the changes. I pinged him to re-review. I also started a retest for the Jenkins tests as this particular change has been sitting there for a while. Regarding [TRAFODION-3089] DatabaseMetaData.getIndexInfo not work well, https://github.com/apache/trafodion/pull/1603: It also wasn't clear to me if the reviewers approved the changes. So I pinged them. I also started a retest since this has been sitting there for a while. Dave -----Original Message----- From: [email protected] <[email protected]> Sent: Tuesday, December 18, 2018 5:39 PM To: [email protected] Subject: Someone could help to review and merge code hi all: I had done several PR to TRAFODION, but it's really a long time that no response, is there anyone who have free time could help to review & merge them [TRAFODION-3246] support TLS for jdbc https://github.com/apache/trafodion/pull/1765 [TRAFODION-3250] optimize get/set schema https://github.com/apache/trafodion/pull/1764 [TRAFODION-3247] support customer define client charset https://github.com/apache/trafodion/pull/1760 [TRAFODION-3183] fetch huge data give rise to core https://github.com/apache/trafodion/pull/1694 [TRAFODION-3089] DatabaseMetaData.getIndexInfo not work well https://github.com/apache/trafodion/pull/1603 thanks, shengchen.ma
