Yes it is already implemented :-)
-----Original Message-----
From: Qifan Chen [mailto:[email protected]]
Sent: Friday, August 7, 2015 4:20 PM
To: dev
Subject: Re: For small scanner feature, regression test?
Hi Eric,
One thing that will be very useful for plan exanimation is to show the small
scan property (when set, in red below :-)) , if that has not been done.
HBASE_SCAN ================================ SEQ_NO 1 NO CHILDREN
TABLE_NAME ............... foo
REQUESTS_IN .............. 1
ROWS_OUT ..... 1,000,000,000
EST_OPER_COST ...... 426,968.16
EST_TOTAL_COST ..... 426,968.16
DESCRIPTION
max_card_est ........... 1e+09
fragment_id ............ 3
parent_frag ............ 2
* small_scan ............. true*
fragment_type .......... esp
scan_type .............. subset scan of table HBASE."_CELL_"."foo" T2
object_type ............ Hbase_Cell
cache_size ........ 10,000
cache_blocks ........... OFF
probes ................. 1
rows_accessed .......... 1e+09
key_columns ............ TRAFODION.SEABASE.T1.ROW_ID
begin_key .............. (TRAFODION.SEABASE.T1.ROW_ID = \:_sys_HostVarLo0)
end_key ................ (TRAFODION.SEABASE.T1.ROW_ID = \:_sys_HostVarHi0)
The code to do so is in GenExplain.cpp
ExplainTuple *
HbaseAccess::addSpecificExplainInfo(ExplainTupleMaster *explainTuple,
ComTdb * tdb,
Generator *generator)
{
NAString description("scan_type: " + getTypeText());
if (getTableDesc()->getNATable()->isSeabaseTable())
{
if (getTableDesc()->getNATable()->isSeabaseMDTable())
description += " object_type: Trafodion_MD ";
else
description += " object_type: Trafodion ";
}
else if (getTableDesc()->getNATable()->isHbaseCellTable())
description += " object_type: Hbase_Cell ";
else if (getTableDesc()->getNATable()->isHbaseRowTable())
description += " object_type: Hbase_Row ";
// add HbaseSearch info
NAString keyInfo(" ");
if ( listOfUniqueRows_.entries() > 0 ) {
keyInfo.append(listOfUniqueRows_.getText());
}
On Fri, Aug 7, 2015 at 3:56 PM, Suresh Subbiah <[email protected]>
wrote:
> Hi Eric,
>
> I would suggest appending to an existing test since you will likely
> not need a lot of queries to get adequate regression coverage.
>
> Thanks
> Suresh
>
>
> On Fri, Aug 7, 2015 at 3:24 PM, Eric Owhadi <[email protected]> wrote:
>
> > Cool, and I assume I can pick an existing one and append to it,
> > right? No need to create a new standalone...
> > Eric
> >
> > -----Original Message-----
> > From: Anoop Sharma [mailto:[email protected]]
> > Sent: Friday, August 7, 2015 3:20 PM
> > To: [email protected]
> > Subject: RE: For small scanner feature, regression test?
> >
> > regress/executor
> >
> > yes, you should add the test as part of your checkin.
> >
> >
> > anoop
> >
> > -----Original Message-----
> > From: Eric Owhadi [mailto:[email protected]]
> > Sent: Friday, August 7, 2015 1:15 PM
> > To: [email protected]
> > Subject: For small scanner feature, regression test?
> >
> > Not sure under what category I should be implementing regression
> > test for the small scanner feature?
> >
> > First question: is regression test development testing the new
> > feature something we must do before being able to trigger a pull
> > request? Or can
> it
> > be a separate JIRA done later?
> >
> > Second question, since the feature involves changes in many layers,
> > under what category should I do regression for small scanner?
> >
> > Eric
> >
>
--
Regards, --Qifan
