Hi Gunnar, In this particular instance, it is not huge deal, but it is setting precedent for PDF or other image files. As you say, there may be files that our dev community want to share for presentations, or what have you. My preference would be to put that stuff in the wiki, if that is okay.
To get your pull-request in, I think you'll not only need to remove the 3 ai files, but create a new branch to submit, without those three files in the branch history. Otherwise, the files are still pulled into the master branch history. To do that, my suggestion is: - close pull request - on current (TRAFODION-182) branch, git rm *.ai; git commit - create new branch based on origin/master - git merge --squash TRAFODION-1822 - create new pull-request from new branch --Steve > -----Original Message----- > From: Gunnar Tapper [mailto:[email protected]] > Sent: Monday, February 29, 2016 5:35 PM > To: [email protected] > Subject: Re: Build failures > > Either is good for me. Let me know. I'll add the .ai info to the > Contributor Guide. > > On Mon, Feb 29, 2016 at 5:39 PM, Steve Varnau <[email protected]> > wrote: > > > Hi, > > > > Thanks for the info on "ai" format. It might be good to add info to the > > logo.md or wiki regarding it. The other image files show up nicely on > > github, but it does not know what to do with ai files. > > > > Regarding where to put image files, I think there are only 2 real > > options: > > 1) continue with putting it here in the source repo docs tree. > > 2) put them on wiki. There is versioning history there. > > > > Each apache project only gets one source repo. I don't think this > > qualifies > > as a sub-project. There is the incubator-trafodion-site repo, but that > > is > > just a publishing mechanism, not meant as a source control location. It > > is > > not mirrored to github, etc. > > > > As we've mentioned, there are pro/con with either answer. > > > > --Steve > > > > > > > -----Original Message----- > > > From: Gunnar Tapper [mailto:[email protected]] > > > Sent: Friday, February 26, 2016 3:43 PM > > > To: [email protected] > > > Subject: Re: Build failures > > > > > > Oops, Ken isn't on this DL. As it turns out, saving the .ai file in > > > .svg > > > format doesn't work well since it messes up the font. So, I downloaded > > > Inkscape (free tool, GPL) to verify that it can import .ai files for > > > editing. That worked just fine even though I don't have the correct > > > fonts > > > installed on my system. > > > > > > Conclusion: storing the logo source files in .ai format does not pose > > > a > > > problem. > > > > > > However, I STRONGLY suggest a separate repository for these type of > > > objects. For example, the artwork used for the carousel on the front > > > page > > > and upcoming presentation templates. > > > > > > Thanks, > > > > > > Gunnar > > > > > > On Fri, Feb 26, 2016 at 1:03 PM, Gunnar Tapper > <[email protected]> > > > wrote: > > > > > > > Ken will have to answer that question since he provided the .ai > > > > files. > > > > > > > > On Fri, Feb 26, 2016 at 12:14 PM, Steve Varnau > <[email protected] > > > > > > > wrote: > > > > > > > >> I don't know much about working with graphics, so let me ask naïve > > > >> question. > > > >> > > > >> Is ai format an open format that will be useable by folks that > > > >> don't > > > >> have > > > >> Adobe Illustrator? > > > >> Is there a more open format we could use? SVG? > > > >> > > > >> --Steve > > > >> > > > >> > > > >> > -----Original Message----- > > > >> > From: Gunnar Tapper [mailto:[email protected]] > > > >> > Sent: Friday, February 26, 2016 9:53 AM > > > >> > To: [email protected] > > > >> > Subject: Re: Build failures > > > >> > > > > >> > .ai files are source files for the logos, which are created in > > > >> > Adobe > > > >> > Illustrator (ai). > > > >> > > > > >> > As mentioned earlier, the source for artwork and other > > > >> > illustrations > > > >> need > > > >> > to live somewhere. If the source tree isn't the right place, then > > > >> > I > > > >> > suggest > > > >> > the creation of a separate git repository to ensure that we don't > > > >> > lose > > > >> the > > > >> > source. > > > >> > > > > >> > On Fri, Feb 26, 2016 at 10:32 AM, Steve Varnau > > > <[email protected]> > > > >> > wrote: > > > >> > > > > >> > > Several of the image files passed the checks. Is there a > > > >> > > reason > > > >> > > that > > > >> > > three > > > >> > > of them are in PDF ("ai" file suffix), rather than the .jpg and > > > >> > > .png > > > >> > > formats > > > >> > > the other files are in? > > > >> > > > > > >> > > --Steve > > > >> > > > > > >> > > > > > >> > > > -----Original Message----- > > > >> > > > From: Gunnar Tapper [mailto:[email protected]] > > > >> > > > Sent: Thursday, February 25, 2016 8:09 PM > > > >> > > > To: [email protected] > > > >> > > > Subject: Re: Build failures > > > >> > > > > > > >> > > > I guess this is a question of whether we want the logo to be > > > >> > > > under > > > >> > > > change > > > >> > > > control. The same question applies to other source files used > > > >> > > > to > > > >> > > > create > > > >> > > > illustrations in manuals, presentations, etc. The source has > > > >> > > > to > > > >> > > > be > > > >> > > > stored > > > >> > > > *somewhere* in order to ensure that illustrations can be > > > >> > > > recreated > > > >> and > > > >> > > > updated. > > > >> > > > > > > >> > > > If not requiring source control, then is a wiki really the > > > >> > > > correct > > > >> > > > place > > > >> > > > for this type of file. Or, is it better to create a separate > > > >> > > > source > > > >> > > > tree > > > >> > > > on > > > >> > > > git for this specific purpose? > > > >> > > > > > > >> > > > Thanks, > > > >> > > > > > > >> > > > Gunnar > > > >> > > > > > > >> > > > On Thu, Feb 25, 2016 at 6:09 PM, Steve Varnau < > > > >> [email protected]> > > > >> > > > wrote: > > > >> > > > > > > >> > > > > The current check for image files accepts these patterns > > > >> > > > > from > > > >> > > > > the > > > >> > > > > file > > > >> > > > > command: 'image|Image|icon|data|PC bitmap' > > > >> > > > > (usually ico, jpeg, png files). Also it checks that any > > > >> > > > > binary > > > >> files > > > >> > > are > > > >> > > > > small (< 180k). > > > >> > > > > > > > >> > > > > If there is good reason to relax those constraints, then > > > >> > > > > this > > > >> > > > > is > > > >> the > > > >> > > > > place > > > >> > > > > to discuss. > > > >> > > > > > > > >> > > > > The reason to restrict binary files is that they live in > > > >> > > > > the > > > >> > > > > git > > > >> > > history > > > >> > > > > forever, even if later changed/deleted, and come with any > > clone > > > >> > > > > of > > > >> > > > > the > > > >> > > > > source tree. If there are larger binary files that need to > > > >> > > > > be > > > >> > > > > published, > > > >> > > > > then the wiki or other places might suffice. > > > >> > > > > > > > >> > > > > --Steve > > > >> > > > > > > > >> > > > > > > > >> > > > > > -----Original Message----- > > > >> > > > > > From: Gunnar Tapper [mailto:[email protected]] > > > >> > > > > > Sent: Thursday, February 25, 2016 4:42 PM > > > >> > > > > > To: [email protected] > > > >> > > > > > Subject: Re: Build failures > > > >> > > > > > > > > >> > > > > > How do I check in the logo source? > > > >> > > > > > > > > >> > > > > > On Thu, Feb 25, 2016 at 5:10 PM, Steve Varnau < > > > >> > > [email protected]> > > > >> > > > > > wrote: > > > >> > > > > > > > > >> > > > > > > You want to look at console of the sub-job: > > > >> > > > > > > https://jenkins.esgyn.com/job/static-checks/721/console > > > >> > > > > > > > > > >> > > > > > > It's complaining that "ai" file type is showing as PDF. > > > >> > > > > > > It > > > >> > > > > > > is > > > >> > > > > > > not > > > >> > > on > > > >> > > > > the > > > >> > > > > > > list of file types we normally allow. > > > >> > > > > > > > > > >> > > > > > > --Steve > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > -----Original Message----- > > > >> > > > > > > > From: Gunnar Tapper [mailto:[email protected]] > > > >> > > > > > > > Sent: Thursday, February 25, 2016 3:36 PM > > > >> > > > > > > > To: [email protected] > > > >> > > > > > > > Subject: Build failures > > > >> > > > > > > > > > > >> > > > > > > > Is something going on with the build environment? I > > > >> > > > > > > > see > > > >> > > > > > > > several > > > >> > > > > failed > > > >> > > > > > > > builds at the same time? > > > >> > > > > > > > > > > >> > > > > > > > > > https://jenkins.esgyn.com/job/Check-PR-master/462/console > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > -- > > > >> > > > > > > > Thanks, > > > >> > > > > > > > > > > >> > > > > > > > Gunnar > > > >> > > > > > > > *If you think you can you can, if you think you can't > > > >> > > > > > > > you're > > > >> > > > > > > > right.* > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > -- > > > >> > > > > > Thanks, > > > >> > > > > > > > > >> > > > > > Gunnar > > > >> > > > > > *If you think you can you can, if you think you can't > > > >> > > > > > you're > > > >> > > > > > right.* > > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > -- > > > >> > > > Thanks, > > > >> > > > > > > >> > > > Gunnar > > > >> > > > *If you think you can you can, if you think you can't you're > > > >> > > > right.* > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > -- > > > >> > Thanks, > > > >> > > > > >> > Gunnar > > > >> > *If you think you can you can, if you think you can't you're > > > >> > right.* > > > >> > > > > > > > > > > > > > > > > -- > > > > Thanks, > > > > > > > > Gunnar > > > > *If you think you can you can, if you think you can't you're right.* > > > > > > > > > > > > > > > > -- > > > Thanks, > > > > > > Gunnar > > > *If you think you can you can, if you think you can't you're right.* > > > > > > -- > Thanks, > > Gunnar > *If you think you can you can, if you think you can't you're right.*
